Skip to content

Updated test scripts for v2 apps#301

Merged
ijlee2 merged 1 commit into
mainfrom
update-test-scripts
May 6, 2026
Merged

Updated test scripts for v2 apps#301
ijlee2 merged 1 commit into
mainfrom
update-test-scripts

Conversation

@ijlee2
Copy link
Copy Markdown
Owner

@ijlee2 ijlee2 commented May 6, 2026

Background

In ijlee2/embroider-css-modules#247, I needed to update the test script so that tests will pass on ember-source@7.0.0.

It's important to note that NODE_ENV (process.env.NODE_ENV) and modes are two different concepts. Here's how different commands affect the NODE_ENV and mode:

Command NODE_ENV Mode
vite build "production" "production"
vite build --mode development "production" "development"
NODE_ENV=development vite build "development" "production"
NODE_ENV=development vite build --mode development "development" "development"

https://vite.dev/guide/env-and-mode#node-env-and-modes

@ijlee2 ijlee2 added the enhance: dependency Issue asks for a new or updated dependency label May 6, 2026
@ijlee2 ijlee2 marked this pull request as ready for review May 6, 2026 13:20
@ijlee2 ijlee2 merged commit 1cb0be8 into main May 6, 2026
27 checks passed
@ijlee2 ijlee2 deleted the update-test-scripts branch May 6, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhance: dependency Issue asks for a new or updated dependency

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant