Conversation
The docker-publish workflow triggers on `v*` tag pushes, but the release tag is pushed by the deploy job using GITHUB_TOKEN, and GitHub does not start workflows from events raised by the built-in token. So the image tags (iklob1/lightapi: <version>, :latest) were never built automatically on release; only :master built, from the pre-bump version (without new library changes). Build and push the image in the same deploy job, right after the tag is created, using the just-published version. This makes :<version> and :latest exist for every release atomically, with no dependency on cross-workflow triggering. A short poll waits for the version to be installable from PyPI before building (the Dockerfile installs lightapi==<version> from PyPI). docker-publish.yml is unchanged; its tag/master/manual triggers still work for human-pushed tags and manual runs. Claude-Session: https://claude.ai/code/session_01LWV5jPTwsAehx2rM7UZjtq
ci: build Docker image in the release job (fix image not built on release)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote dev to master. Brings the CI fix that builds iklob1/lightapi: + :latest inside the PyPI publish job.
This release is the real test of that fix: the image should be built automatically by the publish job, with no manual
gh workflow run.https://claude.ai/code/session_01LWV5jPTwsAehx2rM7UZjtq