Skip to content

Add separate pipeline to check output against ESGF QA#41

Draft
Claude wants to merge 8 commits intomainfrom
claude/add-separate-pipeline-for-output-check
Draft

Add separate pipeline to check output against ESGF QA#41
Claude wants to merge 8 commits intomainfrom
claude/add-separate-pipeline-for-output-check

Conversation

@Claude
Copy link
Copy Markdown
Contributor

@Claude Claude AI commented Apr 14, 2026

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.


This section details on the original issue you should resolve

<issue_title>pipeline that checks output against https://github.com/ESGF/esgf-qa</issue_title>
<issue_description>https://github.com/ESGF/esgf-qa

separate pipeline

can be used on the current unit-test output to start</issue_description>

Comments on the Issue (you are @claude[agent] in this section)

Claude AI and others added 2 commits April 14, 2026 12:13
Agent-Logs-Url: https://github.com/ilaflott/fremorizer/sessions/61e607c6-e3db-44c2-991a-6070db013d2a

Co-authored-by: ilaflott <6273252+ilaflott@users.noreply.github.com>
@Claude Claude AI requested a review from ilaflott April 14, 2026 12:16
@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 14, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

@@           Coverage Diff           @@
##             main      #41   +/-   ##
=======================================
  Coverage   95.03%   95.03%           
=======================================
  Files          10       10           
  Lines        1310     1310           
=======================================
  Hits         1245     1245           
  Misses         65       65           

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68ab12a...2a76a38. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Owner

@ilaflott ilaflott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add esgf_qa directly to the package requirements and env, lets see if they're compatible

Comment thread .github/workflows/esgf_qa_check.yml Outdated
echo "printing conda config just in case"
conda config --show

- name: Install dependencies
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

target the environment.yaml for this repo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated to use environment-file: environment.yaml in the Setup Conda step, following the pattern from pylint.yml. Removed manual dependency installation. (2a69df6)

@Claude
Copy link
Copy Markdown
Contributor Author

Claude AI commented Apr 14, 2026

add esgf_qa directly to the package requirements and env, lets see if they're compatible

Done. Added esgf-qa to environment.yaml as a pip dependency and to pyproject.toml as an optional qa dependency. (2a69df6)

@Claude Claude AI requested a review from ilaflott April 14, 2026 15:07
@ilaflott ilaflott changed the title [WIP] Add separate pipeline to check output against ESGF QA Add separate pipeline to check output against ESGF QA Apr 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pipeline: checks output against https://github.com/ESGF/esgf-qa

3 participants