Repository navigation
fix: pin Rust toolchain via rust-toolchain.toml, fix deprecated f64 path - #15
Merged
Merged
Conversation
CI's dtolnay/rust-toolchain@stable floats to the newest stable, so its clippy -D warnings gate drifts ahead of local toolchains - rustc 1.99 newly deprecates the std::f64 module constants, failing lint-rust on a 'use std::f64' in config.rs tests (local 1.97 was silent). Remove the import so f64::INFINITY resolves to the associated constant. Pin 1.99.0 in rust-toolchain.toml: rustup applies it automatically to local builds, CI, and the V8 archive builder containers, making lint results reproducible everywhere. Bump deliberately; same policy as the ruff pin (#14).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Third unpinned-toolchain incident (Docker tag → ruff → now rustc): CI's
dtolnay/rust-toolchain@stablefloats to the newest stable, soclippy --tests -D warningsenforces rules local toolchains haven't seen. Rust 1.99 deprecates thestd::f64module constants, failing macOS CI on ause std::f64;in test code while local 1.97 stayed silent.Mechanism
rustup applies it automatically wherever cargo runs from the repo: local dev, CI (overrides whatever the setup action installed), and the V8 archive builder containers. One file, every environment, deliberate bumps.
Blast radius
rust-toolchain.toml(new)src/runtime/config.rsuse std::f64;sof64::INFINITYresolves to the non-deprecated associated constantdocs/contributing/development.mdValidation
Local toolchain upgraded to 1.99.0 (matching CI);
make allpasses end-to-end: clippy-D warningsclean, 291 tests.rustup show active-toolchainconfirms the pin takes effect from the repo directory.