ImageJ LUT <-> ImgLib2 ColorTable conversion #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on Image.sc Forum. There might be relevant details there: https://forum.image.sc/t/fiji-friends-weekly-dev-update-thread/103718/110 |
There was a problem hiding this comment.
Pull Request Overview
This PR adds bidirectional conversion utilities between ImageJ's LUT objects and ImgLib2's ColorTable interface. The implementation provides a zero-copy wrapper for LUT-to-ColorTable conversion and a copying converter for ColorTable-to-LUT conversion.
- Added
LUTToColorTable.wrap()for wrapping ImageJ LUTs as ImgLib2 ColorTables without copying data - Added
ColorTableToLUT.convert()for converting ImgLib2 ColorTables to ImageJ LUTs - Added comprehensive test coverage for both conversion directions
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| src/main/java/net/imglib2/imagej/LUTToColorTable.java | Implements zero-copy wrapping of ImageJ LUT into ImgLib2 ColorTable |
| src/main/java/net/imglib2/imagej/ColorTableToLUT.java | Implements copying conversion from ImgLib2 ColorTable to ImageJ LUT |
| src/test/java/net/imglib2/imagej/LUTToColorTableTest.java | Tests the LUT wrapping functionality |
| src/test/java/net/imglib2/imagej/ColorTableToLUTTest.java | Tests the ColorTable conversion functionality |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nice to have over in imglib2-meta.