Skip to content

transpile: Split off convert_floating_literal and refactor - #2024

Draft
Rua wants to merge 9 commits into
immunant:masterfrom
Rua:float-literal-refactor
Draft

Rua wants to merge 9 commits into
immunant:masterfrom
Rua:float-literal-refactor

Conversation

@Rua

@Rua Rua commented Sep 29, 2026 •

Copy link
Copy Markdown
Contributor

This reduces duplicated code in convert_indecrement_operator, and in convert_floating_literal itself by letting make_cast handle the f128 case. It also moves some of the "does this type fit" handling into convert_floating_literal. That means that an implicit convert_cast and convert_expr on a float are completely equivalent from here: convert_cast will always propagate the target type to convert_expr via expected_type_id, where convert_floating_literal will handle any incompatibilities.

@Rua
Rua force-pushed the float-literal-refactor branch 2 times, most recently from a2aab58 to 039d3b0 Compare September 29, 2026 12:57
@Rua
Rua force-pushed the float-literal-refactor branch from 039d3b0 to c2055ba Compare October 9, 2026 12:52
@Rua
Rua force-pushed the float-literal-refactor branch from c2055ba to 0454da1 Compare October 23, 2026 13:30
@Rua
Rua marked this pull request as ready for review October 23, 2026 13:30
@Rua
Rua force-pushed the float-literal-refactor branch from 0454da1 to 8b7fdda Compare November 2, 2026 17:01
@Rua
Rua force-pushed the float-literal-refactor branch from 8b7fdda to 624ae8b Compare November 3, 2026 11:09
@Rua
Rua marked this pull request as draft November 3, 2026 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant