Repository navigation
Conversation
Rua
force-pushed
the
float-literal-refactor
branch
2 times, most recently
from
September 29, 2026 12:57
a2aab58 to
039d3b0
Compare
Rua
force-pushed
the
float-literal-refactor
branch
from
October 9, 2026 12:52
039d3b0 to
c2055ba
Compare
Rua
force-pushed
the
float-literal-refactor
branch
from
October 23, 2026 13:30
c2055ba to
0454da1
Compare
Rua
marked this pull request as ready for review
October 23, 2026 13:30
Rua
force-pushed
the
float-literal-refactor
branch
from
November 2, 2026 17:01
0454da1 to
8b7fdda
Compare
Rua
force-pushed
the
float-literal-refactor
branch
from
November 3, 2026 11:09
8b7fdda to
624ae8b
Compare
Rua
marked this pull request as draft
November 3, 2026 11:10
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ToUnionandNullToPointercasts toconvert_cast#2050This reduces duplicated code in
convert_indecrement_operator, and inconvert_floating_literalitself by lettingmake_casthandle thef128case. It also moves some of the "does this type fit" handling intoconvert_floating_literal. That means that an implicitconvert_castandconvert_expron a float are completely equivalent from here:convert_castwill always propagate the target type toconvert_exprviaexpected_type_id, whereconvert_floating_literalwill handle any incompatibilities.