[ID-3859] feat: Passport prefab#539
Closed
CodeSchwert wants to merge 33 commits into
Closed
Conversation
nattb8
reviewed
Aug 6, 2025
nattb8
reviewed
Aug 6, 2025
nattb8
reviewed
Aug 6, 2025
nattb8
reviewed
Aug 6, 2025
Collaborator
nattb8
left a comment
nattb8
left a comment
There was a problem hiding this comment.
Can we add this prefab to the sample app too? So customers can see a working example of how it's configured?
nattb8
reviewed
Aug 6, 2025
nattb8
reviewed
Aug 6, 2025
nattb8
reviewed
Aug 6, 2025
CodeSchwert
force-pushed
the
feat/passport-prefab
branch
from
44577e2 to
5ff7369
Compare
Contributor
Author
Is that out of scope for this epic?
|
CodeSchwert
force-pushed
the
feat/passport-prefab
branch
from
5973acf to
a57cd86
Compare
Collaborator
Generally we add what goes into the SDK into the sample app too as we often get customers to reference the sample app. I thought it would be a simple addition since it's a prefab. |
CodeSchwert
force-pushed
the
feat/passport-prefab
branch
2 times, most recently
from
a57cd86 to
98a00b3
Compare
nattb8
reviewed
Aug 18, 2025
nattb8
reviewed
Aug 18, 2025
nattb8
reviewed
Aug 18, 2025
- Add browser process isolation workaround for Unity Passport authentication - Configure protocol associations and browser permissions programmatically - Handle both full login flows and cached session scenarios - Fix MailSlurp API URL configuration for OTP retrieval - Implement controlled logout process to prevent app crashes - Increase AltDriver timeouts for CI stability
nattb8
reviewed
Aug 18, 2025
- Change concurrency group from per-platform to shared 'ui-tests-email-inbox' - Ensures macOS and Windows tests run sequentially to avoid MailSlurp race conditions - Prevents OTP emails being consumed by wrong test when tests run in parallel
CodeSchwert
force-pushed
the
feat/passport-prefab
branch
from
d30a1e4 to
5e5b616
Compare
- Move PassportManager.cs and PassportUIBuilder.cs to Samples folder - Remove Unity.Modules.UI and Unity.TextMeshPro dependencies from core SDK - Create separate assembly definition for samples with UI dependencies - Core SDK is now UI-agnostic while preserving drag-and-drop prefab experience - Developers can use provided UI samples or build their own UI
- Add cancel-in-progress: false to ui-tests-email-inbox concurrency group - Allows queued tests to complete rather than being canceled by new runs - Improves CI resource utilization and debugging experience - Maintains existing protection against MailSlurp OTP race conditions
CodeSchwert
force-pushed
the
feat/passport-prefab
branch
from
c38fb47 to
fe27997
Compare
nattb8
reviewed
Aug 19, 2025
Contributor
Author
|
Closed as we decided to go with WebViews and embedded login page instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ID-3859
Customer Impact
Added
Things worth calling out
Other things to consider: