Skip to content

ci(audience): trim playmode PR to 8 cells, add weekly 12-cell run (SDK-327) #746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ImmutableJeffrey merged 1 commit into from
May 7, 2026
Merged

ci(audience): trim playmode PR to 8 cells, add weekly 12-cell run (SDK-327) #746

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
92 changes: 24 additions & 68 deletions .github/workflows/test-audience-sample-app.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,80 +12,48 @@ on:
- 'examples/audience/Packages/**'
- 'examples/audience/ProjectSettings/**'
- '.github/workflows/test-audience-sample-app.yml'
schedule:
# Weekly full-matrix run on the default branch.
# Cron is UTC; cron has no DST awareness, so the local time shifts by one
# hour twice a year. Saturday 14:00 UTC maps to:
# Sun 00:00 Sydney AEST / Sun 02:00 NZ NZST (winter, Apr to Oct)
# Sun 01:00 Sydney AEDT / Sun 03:00 NZ NZDT (summer, Oct to Apr)
- cron: '0 14 * * 6'
workflow_dispatch:

concurrency:
group: ${{ github.workflow }}-${{ github.ref }}
cancel-in-progress: true

jobs:
# Reduced matrix on pull_request, full matrix on schedule and
# workflow_dispatch. The self-hosted Windows runner pool is small, so
# trimming PR cells keeps PR feedback fast. `matrix.exclude` below is
# the source of truth for which cells are dropped on pull_request.
playmode:
if: github.event.pull_request.head.repo.fork == false || github.event_name == 'workflow_dispatch'
if: |
(github.event_name == 'pull_request' && github.event.pull_request.head.repo.fork == false)
|| github.event_name == 'schedule'
|| github.event_name == 'workflow_dispatch'
name: ${{ matrix.target }} / ${{ matrix.backend }} / Unity ${{ matrix.unity }}
strategy:
fail-fast: false
matrix:
unity: ['2021.3.45f2', '6000.4.0f1', '2022.3.62f2']
target: [StandaloneWindows64, StandaloneOSX]
backend: [IL2CPP, Mono2x]
include:
- target: StandaloneWindows64
backend: IL2CPP
unity: 2021.3.45f2
changeset: 88f88f591b2e
runner: [self-hosted, Windows, X64]
- target: StandaloneWindows64
backend: Mono2x
unity: 2021.3.45f2
- unity: '2021.3.45f2'
changeset: 88f88f591b2e
runner: [self-hosted, Windows, X64]
- target: StandaloneOSX
backend: IL2CPP
unity: 2021.3.45f2
changeset: 88f88f591b2e
runner: [self-hosted, macOS, ARM64]
- target: StandaloneOSX
backend: Mono2x
unity: 2021.3.45f2
changeset: 88f88f591b2e
runner: [self-hosted, macOS, ARM64]
- target: StandaloneWindows64
backend: IL2CPP
unity: 6000.4.0f1
changeset: 8cf496087c8f
runner: [self-hosted, Windows, X64]
- target: StandaloneWindows64
backend: Mono2x
unity: 6000.4.0f1
changeset: 8cf496087c8f
runner: [self-hosted, Windows, X64]
- target: StandaloneOSX
backend: IL2CPP
unity: 6000.4.0f1
- unity: '6000.4.0f1'
changeset: 8cf496087c8f
runner: [self-hosted, macOS, ARM64]
- target: StandaloneOSX
backend: Mono2x
unity: 6000.4.0f1
changeset: 8cf496087c8f
runner: [self-hosted, macOS, ARM64]
- target: StandaloneWindows64
backend: IL2CPP
unity: 2022.3.62f2
- unity: '2022.3.62f2'
changeset: 7670c08855a9
runner: [self-hosted, Windows, X64]
- target: StandaloneWindows64
backend: Mono2x
unity: 2022.3.62f2
changeset: 7670c08855a9
runner: [self-hosted, Windows, X64]
- target: StandaloneOSX
backend: IL2CPP
unity: 2022.3.62f2
changeset: 7670c08855a9
runner: [self-hosted, macOS, ARM64]
- target: StandaloneOSX
backend: Mono2x
unity: 2022.3.62f2
changeset: 7670c08855a9
runner: [self-hosted, macOS, ARM64]
exclude: ${{ fromJSON(github.event_name == 'pull_request' && '[{"unity":"2022.3.62f2"}]' || '[]') }}
runs-on: ${{ matrix.runner }}
# Healthy cells finish in ~10 min. 30 min covers cold caches +
# IL2CPP + Unity 6 startup; anything past that is a hang. Capping
Expand Down Expand Up @@ -450,24 +418,12 @@ jobs:
strategy:
fail-fast: false
matrix:
target: [Android, iOS]
Copy link
Copy Markdown

@cursor cursor Bot May 7, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mobile-build if not updated for new schedule trigger

Low Severity

The playmode job's if was explicitly updated to handle the new schedule event, but the mobile-build job's if was not. On schedule events, github.event.pull_request.head.repo.fork is null, and GitHub Actions coerces null == false to true (both become 0), so mobile-build silently runs every week. If this is intended, the condition is fragile and inconsistent with the playmode guard; if unintended, it wastes six extra CI cells weekly.

Additional Locations (2)
Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 69a42d3. Configure here.

unity: ['2021.3.45f2', '2022.3.62f2', '6000.4.5f1']
include:
- target: Android
unity: 2021.3.45f2
method: AndroidBuilder.Build
- target: Android
unity: 2022.3.62f2
method: AndroidBuilder.Build
- target: Android
unity: 6000.4.5f1
method: AndroidBuilder.Build
- target: iOS
unity: 2021.3.45f2
method: IosBuilder.Build
- target: iOS
unity: 2022.3.62f2
method: IosBuilder.Build
- target: iOS
unity: 6000.4.5f1
method: IosBuilder.Build

steps:
Expand Down
Loading