Skip to content

feat: exit on SIGTERM signal#368

Draft
daniel-mader wants to merge 3 commits into
betafrom
feat/handle-sigterm
Draft

feat: exit on SIGTERM signal#368
daniel-mader wants to merge 3 commits into
betafrom
feat/handle-sigterm

Conversation

@daniel-mader

@daniel-mader daniel-mader commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Description of change

The application should handle SIGTERM commands and exit immediately. SIGTERM is currently unhandled and thus Kubernetes waits for 30 seconds, before it forcefully terminates the container. Graceful shutdowns are contrary to Crash-only design, so graceful shutdowns (clean up, flush messages, properly close connections) can not always be expected anyway.

Links to any relevant issues

Be sure to reference any related issues by adding fixes issue #.

How the change has been tested

Describe the tests that you ran to verify your changes.
Make sure to provide instructions for the maintainer as well as any relevant configurations.

Definition of Done checklist

Add an x to the boxes that are relevant to your changes.

  • I have followed the contribution guidelines for this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have successfully tested this change in a docker environment

@daniel-mader daniel-mader self-assigned this Jul 6, 2026
@daniel-mader daniel-mader added the Enhancement New feature or improvement to an existing feature label Jul 6, 2026
@codecov-commenter

codecov-commenter commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 21 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
agent_application/src/lib.rs 0.00% 21 Missing ⚠️
Files with missing lines Coverage Δ
agent_application/src/lib.rs 0.00% <0.00%> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@daniel-mader daniel-mader force-pushed the feat/handle-sigterm branch from e846a0b to 794cd55 Compare July 6, 2026 15:07
@daniel-mader daniel-mader changed the title feat: handle termination signals feat: exit on SIGTERM signal Jul 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Enhancement New feature or improvement to an existing feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants