Fix minute.round with non-integer TZ offsets#46
Merged
vogievetsky merged 3 commits intomasterfrom Nov 29, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix minute.round to respect timezone parameter for non-UTC timezones and non-integer offsets.
The minute.round function was ignoring the timezone parameter, causing incorrect bucket alignment for durations like PT20M when used with timezones that have non-integer hour offsets (e.g., Asia/Kolkata at UTC+5:30).
For example, with PT20M and Asia/Kolkata:
Changes:
The fix follows the same pattern used by hour.round, which already correctly handles timezone-aware rounding.