Skip to content

refactor: bump sea-orm to v2 - #96

Merged
kwaa merged 1 commit into
mainfrom
chore/bump-sea-orm
Aug 23, 2026
Merged

kwaa merged 1 commit into
mainfrom
chore/bump-sea-orm

Conversation

@kwaa

@kwaa kwaa commented Aug 23, 2026 •

Copy link
Copy Markdown
Member

Summary by CodeRabbit

  • Compatibility

    • Updated the minimum supported Rust version to 1.85.
    • Upgraded SeaORM dependencies to version 2.0.
  • Bug Fixes

    • Improved handling of duplicate user records by safely ignoring conflicting inserts.
  • Tests

    • Added SQLite migration coverage to verify migration reruns preserve existing user data.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026 •

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: e87c21bf-9010-4e3e-818c-d9a460726bf3

📥 Commits

Reviewing files that changed from the base of the PR and between e2d0106 and 8b24159.

⛔ Files ignored due to path filters (1)
  • Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (4)
  • Cargo.toml
  • README.md
  • crates/apub/src/actors/db_user.rs
  • crates/db_migration/src/lib.rs

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

The workspace now requires Rust 1.85 and SeaORM 2.0. User ID inserts use the new conflict-ignore helper. A SQLite integration test verifies migration completion, idempotent reruns, migration counts, and preserved user data.

Changes

SeaORM migration upgrade

Layer / File(s) Summary
Workspace compatibility and dependency versions
Cargo.toml, README.md
The workspace minimum Rust version changes to 1.85. The sea-orm and sea-orm-migration dependencies change to 2.0. The README badge reflects Rust 1.85+.
User insert conflict handling
crates/apub/src/actors/db_user.rs
User inserts use on_conflict_do_nothing_on for duplicate user IDs. The unused sea_query import is removed.
SQLite migration integration coverage
crates/db_migration/src/lib.rs
An asynchronous SQLite test runs migrations, checks migration counts, reruns migrations, and verifies that an existing user record remains intact.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Merge Risk: ⚪ Minimal · up to 8b241

The dependency upgrade and related localized changes have no actionable merge-blocking risk identified, so the PR is merge-ready after normal checks and review.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: upgrading SeaORM to version 2.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/bump-sea-orm

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 Clippy (1.97.1)

Clippy execution timed out


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@kwaa
kwaa merged commit ab98879 into main Aug 23, 2026
1 check failed
@kwaa
kwaa deleted the chore/bump-sea-orm branch August 23, 2026 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant