Open
Conversation
mnindrazaka
requested changes
Aug 27, 2020
Collaborator
mnindrazaka
left a comment
mnindrazaka
left a comment
There was a problem hiding this comment.
ada beberapa suggestion yang perlu dipertimbangkan. Sisanya tinggal ditambahkan test dan mekanisme debounce
Comment on lines
80
to
82
| onChange={item => | ||
| projectSyncContext.setSearchByName(item.target.value) | ||
| } |
Collaborator
There was a problem hiding this comment.
kyknya lebih baik kalau dibuatin event handler function di componentnya, misal handleSearchChange dan dibungkus dengan React.useCallback. Sehingga setiap kali rerender tidak akan membuat function baru seperti ini
Comment on lines
28
to
29
| searchByName: string; | ||
| setSearchByName: (searchByName: string) => void; |
Collaborator
There was a problem hiding this comment.
kalau nama state nya diganti dengan searchQuery gimana ? supaya kedepannya satu state ini bisa digunakan untuk berbagai macam pencarian. Gak cuma searchByName aja
Collaborator
Author
There was a problem hiding this comment.
owalah baik mas.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
vidio demo bisa dilihat pada link berikut: https://streamable.com/9fogks