fix(build): recompile devprof when runt.h changes#14
Merged
pdfinn merged 1 commit intoApr 21, 2026
Conversation
Member
|
Thanks for this, @Ticed — verified the dependency was indeed missing (devprof.c:6 includes runt.h, and portmkfile:135-138 declares the $RUNT dep for every other runt.h-including source except this one). Clean fix, matches the surrounding style. Cross-checked against NERVsystems#163 — this PR is the complete applicable subset for this repo (the QUICKSTART.md stale-path fix from that PR doesn't apply here, our copy is already correct on line 123). Approved CI. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
devprof.cincludesrunt.hbut theemu/port/portmkfilerules didnot declare
devprof.$O: $RUNT. Whenrunt.hregenerates,devprof.$Ois not rebuilt, so the emulator can end uplinked against a stale
devprofobject.This adds the missing dependency alongside the existing
devprog.$O: $RUNT/devsrv.$O: $RUNTentries.Companion to the downstream fix in NERVsystems#163 — same dependency gap exists here.