fix: rust allow not invoking all-features in tests #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prestwich
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable all-features input parameter to control whether Rust compilation commands should use the --all-features flag. The intent is to provide flexibility in disabling all-features for binaries unless explicitly enabled.
- Adds
all-featuresboolean input parameter torust-base.ymlwith conditional flag insertion - Updates all cargo commands (nextest, clippy, doc, test) to conditionally include
--all-features - Configures
rust-library-base.ymlto explicitly enableall-features: truewhen callingrust-base.yml
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
.github/workflows/rust-library-base.yml |
Adds all-features: true parameter when calling rust-base workflow |
.github/workflows/rust-base.yml |
Defines new all-features input parameter and conditionally applies --all-features flag to all cargo commands; includes trailing whitespace cleanup |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
prestwich
changed the title
prestwich
changed the title
Member
Author
|
behavior is unchanged unless you specifically set it to false |
rswanson
reviewed
Dec 12, 2025
| CARGO_BUILD_JOBS: ${{ inputs.cargo-build-jobs }} | ||
| run: | | ||
| cargo nextest run --all-features --workspace --locked --cargo-profile ${{ inputs.rust-profile }} --no-tests=warn | ||
| cargo nextest run ${{ inputs.test-all-features && '--all-features' || '' }} --workspace --locked --cargo-profile ${{ inputs.rust-profile }} --no-tests=warn |
rswanson
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a feature to invoke/not-invoke all-features during tests. This allows (e.g.) binaries to disable all-feature testing, which is a common desire in integration tests
claude wrote this