feat(sim): Set appropiate spec id depending on chain #189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes ENG-1506. Appropiately sets the `SpecId` for each chain, depending on which fork is active. This only discriminates between the "expected to activate" hard fork, and the current hard fork.
Member
|
converting to draft pending work discussed on slack |
Contributor
|
What work? Can we document that somewhere? |
prestwich
reviewed
Dec 1, 2025
Member
|
@dylanlott just conforming to the ticket w/ genesis |
prestwich
reviewed
Dec 4, 2025
prestwich
reviewed
Dec 4, 2025
Evalir
force-pushed
the
evalir/spec-id-chain
branch
from
4d78c4b to
0fbe00e
Compare
Evalir
force-pushed
the
evalir/spec-id-chain
branch
from
0fbe00e to
25e0583
Compare
prestwich
reviewed
Dec 8, 2025
Evalir
changed the title
prestwich
reviewed
Dec 9, 2025
prestwich
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes ENG-1506.
Appropiately sets the
SpecIdfor each chain, depending on which fork is active. This only discriminates between the "expected to activate" hard fork, and the current hard fork.