Add keep_alive and max_connections configuration to IncogniaAPI#101
Open
alangalvino wants to merge 3 commits intomainfrom
Open
Add keep_alive and max_connections configuration to IncogniaAPI#101alangalvino wants to merge 3 commits intomainfrom
alangalvino wants to merge 3 commits intomainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Adds optional HTTP connection reuse to the Python client by introducing keep_alive and max_connections configuration and wiring a shared requests.Session through both the API client and token refresh path.
Changes:
- Add
keep_alive/max_connectionsparameters toIncogniaAPIandBaseRequest, enabling a pooledrequests.Sessionwhen configured. - Allow
TokenManagerto accept an injectedBaseRequestso token refresh uses the same connection pool. - Add tests and README documentation describing the new configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
incognia/base_request.py |
Creates and uses a pooled requests.Session via HTTPAdapter when keep_alive=True. |
incognia/api.py |
Exposes keep_alive/max_connections on IncogniaAPI and shares the request instance with TokenManager. |
incognia/token_manager.py |
Supports dependency injection of BaseRequest so auth requests reuse the same session. |
tests/test_base_request.py |
Adds unit tests for the keep-alive/session behavior. |
README.md |
Documents the new keep-alive configuration and shows an example. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR body:
Summary
keep_alive(bool) andmax_connections(int) parameters toIncogniaAPIkeep_alive=True, arequests.Sessionis created with anHTTPAdapterconfigured withpool_connectionsandpool_maxsizeset tomax_connectionsTokenManagerso all requests (including token refresh) benefit from connection reusekeep_alive=False(existing behavior) andmax_connections=10