Skip to content

Conversation

@mkoura
Copy link
Collaborator

@mkoura mkoura commented Sep 10, 2025

Add support for generating mnemonics and deriving extended signing keys from mnemonic sentences. Introduce KeyType and OutputFormat enums. Refactor helpers for file reading. Update KeyGroup with new methods for mnemonic and key derivation.

@mkoura mkoura requested a review from Copilot September 10, 2025 16:28
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds comprehensive support for mnemonic generation and key derivation from mnemonic sentences to the cardano_clusterlib package. It introduces new enums for key types and output formats while refactoring file reading utilities.

  • Added mnemonic generation and key derivation methods to KeyGroup class
  • Introduced KeyType and OutputFormat enums for better type safety
  • Refactored file reading utilities with a new generic helper function

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

File Description
cardano_clusterlib/key_group.py Added gen_mnemonic and derive_from_mnemonic methods with comprehensive key type support
cardano_clusterlib/helpers.py Added read_from_file helper and refactored read_address_from_file to use it
cardano_clusterlib/consts.py Added KeyType and OutputFormat enums for type safety
cardano_clusterlib/clusterlib.py Updated exports to include new KeyType and OutputFormat enums

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Add support for generating mnemonics and deriving extended signing keys
from mnemonic sentences. Introduce KeyType and OutputFormat enums.
Refactor helpers for file reading. Update KeyGroup with new methods
for mnemonic and key derivation.
@mkoura mkoura merged commit d7b9a3b into master Sep 10, 2025
3 checks passed
@mkoura mkoura deleted the add_key_mnemonic branch September 10, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants