feat(cat-voices): Using new stream source for WorkspaceBloc #3785
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LynxLynxx
added
review me
LynxLynxx
requested review from
bstolinski,
damian-molinski and
dt-iohk
as code owners
| } | ||
|
|
||
| void _handleActiveAccountIdChange(CatalystId? id) { | ||
| if (isClosed) return; |
Contributor
There was a problem hiding this comment.
you're closing _activeAccountIdSub on close. This shouldn't be necessary but won't hurt either
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/workspace/workspace_bloc.dart
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/workspace/workspace_bloc.dart
Outdated
Show resolved
Hide resolved
catalyst_voices/packages/internal/catalyst_voices_blocs/lib/src/workspace/workspace_bloc.dart
Show resolved
Hide resolved
...t_voices/packages/internal/catalyst_voices_blocs/lib/src/workspace/workspace_bloc_cache.dart
Show resolved
Hide resolved
...ces/packages/internal/catalyst_voices_repositories/lib/src/proposal/proposal_repository.dart
Outdated
Show resolved
Hide resolved
...ces/packages/internal/catalyst_voices_repositories/lib/src/proposal/proposal_repository.dart
Outdated
Show resolved
Hide resolved
...s/packages/internal/catalyst_voices_view_models/lib/src/proposal/user_proposal_overview.dart
Outdated
Show resolved
Hide resolved
...s/packages/internal/catalyst_voices_view_models/lib/src/proposal/user_proposal_overview.dart
Outdated
Show resolved
Hide resolved
|
|
||
| extension _ProposalPublishExt on ProposalPublish { | ||
| static ProposalPublish getStatus({required bool isFinal, required DocumentRef ref}) { | ||
| if (isFinal && DocumentRef is SignedDocumentRef) { |
Contributor
There was a problem hiding this comment.
DocumentRef is SignedDocumentRef hmmm
Contributor
Author
There was a problem hiding this comment.
Yeah it's not needed because its already final
Contributor
There was a problem hiding this comment.
It was about checking if type is different type. DocumentRef is SignedDocumentRef, instead or variable ref is SignedDocumentRef
Contributor
📚 Docs PreviewThe docs for this PR can be previewed at the following URL: https://docs.dev.projectcatalyst.io/voices/chore/use-new-db-in-workspace |
dt-iohk
reviewed
Nov 28, 2025
...ackages/internal/catalyst_voices_models/lib/src/proposal/proposals_collaboration_status.dart
Outdated
Show resolved
Hide resolved
dt-iohk
approved these changes
Nov 28, 2025
bstolinski
approved these changes
Dec 1, 2025
damian-molinski
approved these changes
Dec 1, 2025
Contributor
damian-molinski
left a comment
damian-molinski
left a comment
There was a problem hiding this comment.
I think there are few unnecessary checks (if(isClosed) return;), especially in stream listeners methods but overall LGTM
LynxLynxx
added a commit
that referenced
this pull request
Dec 1, 2025
* feat: adding translations * chore: update workspace page * chore: update user proposals * feat: workspace proposal filter * chore: adding new implemention of proposal brief * feat: workspace proposal tab * feat: adding new proposal invites * chore: move widgets in widget dir * feat: adding empty state for proposal invites * feat: updating filters * feat: updating filters options * feat: proposal invites count * fix: spelling * chore: review update * feat: adding new options to filters and brief data * feat(cat-voices): Using new stream source for WorkspaceBloc (#3785) * feat: working integration * chore: use bloc instead of cubit * chore: final changes * chore: selfreview * feat: review update * fix: readme * chore: rename factory constructor * feat: merge collaborators status enum into one * fix: format
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Using new stream source for worksapce bloc
Please confirm the following checks