Skip to content

Fix default testing depth #296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
averissimo wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix default testing depth #296

averissimo wants to merge 2 commits into from

Conversation

@averissimo
Copy link
Contributor

@averissimo averissimo commented Dec 19, 2025

Pull Request

  • Fallback to a default TESTING_DEPTH if a helper file is included
  • Make the check agnostic of the target
  • Remove redundant code

@averissimo averissimo requested a review from a team as a code owner December 19, 2025 13:07
@github-actions
Copy link
Contributor

github-actions bot commented Dec 19, 2025

Unit Tests Summary

3 tests   2 ✅  4s ⏱️
3 suites  1 💤
1 files    0 ❌

Results for commit e89d546.

llrs-roche
llrs-roche approved these changes Dec 19, 2025
View reviewed changes
Copy link
Contributor

@llrs-roche llrs-roche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for also opening to other target branches.
Great renaming of the variable.

This was tested on TMC insightsengineering/teal.modules.clinical#1452, on this step we can see it reset to the workflow default.

@llrs-roche llrs-roche self-assigned this Dec 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@llrs-roche llrs-roche llrs-roche approved these changes

Assignees

@llrs-roche llrs-roche

Labels

core

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@averissimo @llrs-roche