1444: add CMH with Wilson-Hilferty transformation #1448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…be NA also for cmh?
Collaborator
Author
|
I have read the CLA Document and I hereby sign the CLA |
…wise it will be flaky between platforms
Melkiades
reviewed
Dec 8, 2025
Melkiades
reviewed
Dec 8, 2025
Comment on lines
+12
to
+13
| #' @param method (`string`)\cr one of `chisq`, `cmh`, `cmh_wh`, `fisher`, or `schouten`; | ||
| #' specifies the test used to calculate the p-value. |
Contributor
There was a problem hiding this comment.
Maybe also here the citations? I am happy anyway with this PR (it will need to be merged with the other but it should be straight forwards)
Collaborator
Author
There was a problem hiding this comment.
Sure, maybe you can first merge the other PR, then it is easier to continue with this one
Contributor
|
hi Daniel, can you add the following lines to the DESCRIPTION this will help to get the right versions |
Contributor
|
also need to bump the minimal version for formatters and rtables in the description |
Collaborator
Author
|
After the first PR is merged, I will continue with this one. Let's first get the first one done |
Collaborator
Author
|
moving to internal branch now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1444