Fixed issue with pasting text generates a javascript error#110
Open
dnetherton wants to merge 1 commit intoinsin:masterfrom
Open
Fixed issue with pasting text generates a javascript error#110dnetherton wants to merge 1 commit intoinsin:masterfrom
dnetherton wants to merge 1 commit intoinsin:masterfrom
Conversation
Contributor
|
👍 |
dwbruhn
added a commit
to dwbruhn/react-maskedinput
that referenced
this pull request
Sep 28, 2017
Side effects: 1) Delete behavior now allows removal of more than one character 2) Cut now shifts remaining characters left instead of leaving "hole" Also fix binding of this._updateInputSelection (cf. insin#110)
iamdustan
pushed a commit
that referenced
this pull request
Oct 20, 2017
Side effects: 1) Delete behavior now allows removal of more than one character 2) Cut now shifts remaining characters left instead of leaving "hole" Also fix binding of this._updateInputSelection (cf. #110)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I hit a bug, where pasting content in masked input, generates a javascript error.
I havent looked to close, but i suspect, when the component was converted to class format (from createClass()), that the binding for the function _updateInputSelection was missed.
Also, not sure if there are other functions that also need binding.
Regards
Dean Netherton