test: replaced node-fetch with native fetch in test setup #2022
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aryamohanan
force-pushed
the
test-node-fetch
branch
from
f6e2ca8 to
9a12921
Compare
aryamohanan
force-pushed
the
test-node-fetch
branch
2 times, most recently
from
8ae3d4d to
9b3dec7
Compare
Contributor
aryamohanan
force-pushed
the
test-node-fetch
branch
from
9b3dec7 to
1c4034b
Compare
aryamohanan
force-pushed
the
test-node-fetch
branch
2 times, most recently
from
0cc24d2 to
55c8ff6
Compare
aryamohanan
force-pushed
the
test-node-fetch
branch
from
a2d3f22 to
72fbfc4
Compare
aryamohanan
commented
Jan 2, 2026
| 'request to http://127.0.0.1:65212/ failed, reason: connect ' + | ||
| 'ECONNREFUSED 127.0.0.1:65212 -- console.error - should be traced' | ||
| )); | ||
| runAndTrace('exit-span', true, 'fetch failed -- console.error - should be traced')); |
Contributor
Author
There was a problem hiding this comment.
Native fetch and node-fetch represent the same failure; they are just surfaced differently.
Native fetch:
- Throws a TypeError: fetch failed
- The real cause is nested under error.cause
node-fetch:
- Throws a FetchError
- The connection error is exposed directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate test setup files from
node-fetchto native fetch API (available in Node.js 18+). This change removes the dependency on thenode-fetchpackage in test code and leverages the built-in fetch functionality.ref https://jsw.ibm.com/browse/INSTA-15850