Skip to content

Harden Arch PKGBUILD checks by falling back to mkntfs when mkfs.ntfs is absent#148

Draft
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-build-arch-package
Draft

Harden Arch PKGBUILD checks by falling back to mkntfs when mkfs.ntfs is absent#148
Copilot wants to merge 3 commits into
mainfrom
copilot/fix-build-arch-package

Conversation

Copilot AI commented Jun 6, 2026

Copy link
Copy Markdown

The Build Arch package GitHub Actions job failed during makepkg test execution because NTFS test setup assumed mkfs.ntfs exists on PATH. In some Arch environments, ntfs-3g provides mkntfs instead, causing the NTFS E2E resize test to fail before package build completion.

  • Root-cause alignment

    • Removed the hard dependency on a single NTFS formatter binary name in dualboot test utilities.
  • NTFS formatter invocation

    • Introduced a small helper in src/arch/dualboot/test_utils.rs that:
      • tries mkfs.ntfs first
      • falls back to mkntfs on NotFound
      • preserves existing failure behavior for all other execution errors
  • Diagnostics

    • Improved missing-binary error text to explicitly report both attempted commands.
  • Targeted test coverage

    • Added a focused test that validates NTFS formatter invocation through the shared helper path.
for formatter in ["mkfs.ntfs", "mkntfs"] {
    match Command::new(formatter).arg("-F").arg("-Q").arg(path).status() {
        Ok(status) => return Ok(status),
        Err(err) if err.kind() == ErrorKind::NotFound => continue,
        Err(err) => return Err(err),
    }
}

Copilot AI changed the title [WIP] Fix failing GitHub Actions job Build Arch package Harden Arch PKGBUILD checks by falling back to mkntfs when mkfs.ntfs is absent Jun 6, 2026
Copilot AI requested a review from paperbenni June 6, 2026 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants