[MBL-19874][All] Privacy Consent dialog#3613
Open
hermannakos wants to merge 22 commits intomasterfrom
Open
Conversation
refs: MBL-19875 affects: Student, Teacher, Parent release note: none test plan: You'll need local canvas to test as of now. Go to each section that uses a webview, and navigate around, while checking the following: There must be no console warning saying "OneTrust would initialize." The window.JS_ENV object should contain MOBILE_COOKIE_CONSENT with a boolean true value. Close the client. Set the mobile_consent passed-on value to “false”. Do the same as previously, MOBILE_COOKIE_CONSENT should show a boolean false value, and the console warning should not be visible.
refs: MBL-19874 affects: Student, Teacher, Parent release note: Added consent screen for anonymous analytics. test plan: Use beta. Check the ticket. Enable the cookie consent feature flag. 1. Check if the dialog appears on the first app open after the ff was enabled. 2. Subsequent opens don't display the dialog. 3. The dialog is accessible via the Settings > Legal screen too.
# Conflicts: # libs/pandautils/src/test/java/com/instructure/pandautils/domain/usecase/session/GetAuthenticatedSessionUseCaseTest.kt
Contributor
🧪 Unit Test Results❌ 📱 Parent App
❌ Failed Tests (2)
✅ 📱 Student App
✅ 📱 Teacher App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Fri, 24 Apr 2026 14:55:27 GMT |
Contributor
📊 Code Coverage Report
|
Contributor
|
Parent Install Page |
Contributor
|
Teacher Install Page |
tamaskozmer
requested changes
Apr 1, 2026
tamaskozmer
approved these changes
Apr 7, 2026
Contributor
|
Student Install Page |
# Conflicts: # apps/student/src/main/java/com/instructure/student/features/login/StudentAcceptableUsePolicyRouter.kt
kdeakinstructure
previously requested changes
Apr 24, 2026
Contributor
There was a problem hiding this comment.
- With QR Login, the dialog won't be displayed even though it is the first login attempt after installing the apps.
- In Teacher, when the user uses the "Student View" feature, the student app will be opened with the "Test Student" dummy user, but the dialog won't be displayed this time. (This might be intentional if we don't want to track this particular dummy user's activities).
kristofnemere
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
refs: MBL-19874, MBL-19966
affects: Student, Teacher, Parent
release note: Added privacy consent dialog for anonymous analytics (Pendo).
Summary
cookie_consent_necessaryaccount-level feature flag is enabled (MBL-19874)ApiPrefs.mobileConsent(nullable boolean:null= not yet decided,true/false= decided) — replaces the previous network API call (MBL-19966)GlobalScope)mobileConsentstateTest plan
Enable the
cookie_consent_necessaryfeature flag, then:Checklist
🤖 Generated with Claude Code
Co-Authored-By: Claude noreply@anthropic.com