[MBL-19927][Student] NGC Course Home screen#3661
Open
hermannakos wants to merge 4 commits intomasterfrom
Open
Conversation
Add course home screen with collapsing toolbar, segmented tab control, and navigation from dashboard. The screen loads course data via LoadSingleCourseUseCase and resolves course color through the InstUI theme's new LocalCourseColor CompositionLocal. New InstUI components: - CollapsingTopBar: collapsing toolbar with leading content slot, accent color transitions, and content color interpolation - SegmentedControl: wrapper around Material3 SecondaryTabRow - LocalCourseColor on InstUITheme for course color propagation Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…tedControl Add unit tests for CourseHomeViewModel covering loading, error, tab selection, and course image states. Switch to LoadCourseUseCase (REST). Update SegmentedControl to use course accent color for selected text and indicator. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add placeholder screens for each course home tab: - CourseOverviewScreen (Home tab) - CourseModulesScreen (Modules tab) - CourseMyWorkScreen (My Work tab) - CourseNavigationScreen (More tab) Each uses LazyColumn to support collapsing toolbar scroll. Refactor NGC features into features/ package structure. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Route deep links to NGCActivity when the next_gen_canvas remote config
flag is enabled. InterwebsToApplication now checks NGC before Career
and old experience routing.
Register navDeepLink patterns on the CourseHome route for https, http,
canvas-courses, and canvas-student schemes matching /courses/{courseId}.
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
🧪 Unit Test Results✅ 📱 Student App
✅ 🌅 Horizon
✅ 📦 Submodules
📊 Summary
Last updated: Thu, 23 Apr 2026 11:22:05 GMT |
Contributor
📊 Code Coverage Report
|
Contributor
|
Student Install Page |
kristofnemere
requested changes
Apr 24, 2026
| import com.instructure.instui.compose.navigation.SegmentedControl | ||
| import com.instructure.instui.token.semantic.InstUILayoutSizes | ||
|
|
||
| private val TAB_LABELS = listOf("Home", "Modules", "My Work", "More") |
Contributor
There was a problem hiding this comment.
We should use string resources
kristofnemere
requested changes
Apr 24, 2026
Contributor
kristofnemere
left a comment
kristofnemere
left a comment
There was a problem hiding this comment.
UI Finding:
- The back button seems too big, and different that on the design
- The tab names breaking weird (on smaller screens)
- The tabs are different that on design
- The collapsing toolbar animation is weird, some polishing would be nice
- Not sure if we want to change tabs by swipe but it's not working rn.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CollapsingTopBar,SegmentedControl,LocalCourseColoronInstUIThemenext_gen_canvasremote config flag is enabledCourseHomeViewModelwith unit testsTest plan
next_gen_canvasremote config flagadb shell am start -a android.intent.action.VIEW -d "https://<domain>/courses/<id>"refs: MBL-19927
affects: Student
release note: New course home screen with collapsing toolbar and tabbed navigation
🤖 Generated with Claude Code