[MBL-19970][All] - Fix Help Menu E2E tests by kdeakinstructure · Pull Request #3664 · instructure/canvas-android

kdeakinstructure · 2026-04-24T09:03:51Z

Fix breaking Help Menu E2E tests in all the apps (Changed some strings and Intent URLS)

refs: MBL-19970
affects: Parent, Student, Teacher
release note: -

Run E2E test suite

…s and Intent URLS) refs: MBL-19970 affects: Parent, Student, Teacher release note: -

github-actions · 2026-04-24T09:18:15Z

🧪 Unit Test Results

✅ 📱 Parent App

Tests: 315 total, 0 failed, 0 skipped
Duration: 34.996s
Success Rate: 100%

✅ 📱 Student App

Tests: 1210 total, 0 failed, 0 skipped
Duration: 0.000s
Success Rate: 100%

✅ 📱 Teacher App

Tests: 364 total, 0 failed, 0 skipped
Duration: 31.697s
Success Rate: 100%

✅ 🌅 Horizon

Tests: 779 total, 0 failed, 0 skipped
Duration: 35.562s
Success Rate: 100%

✅ 📦 Submodules

Tests: 3407 total, 0 failed, 0 skipped
Duration: 54.598s
Success Rate: 100%

📊 Summary

Total Tests: 6075
Failed: 0
Skipped: 0
Status: ✅ All tests passed!

Last updated: Fri, 24 Apr 2026 13:47:16 GMT

github-actions · 2026-04-24T09:18:44Z

📊 Code Coverage Report

✅ Student

PR Coverage: 42.61%
Master Coverage: 42.61%
Delta: +0.00%

✅ Teacher

PR Coverage: 25.26%
Master Coverage: 25.26%
Delta: +0.00%

✅ Pandautils

PR Coverage: 23.99%
Master Coverage: 23.99%
Delta: +0.00%

📈 Overall Average

PR Coverage: 30.62%
Master Coverage: 30.62%
Delta: +0.00%

github-actions · 2026-04-24T09:27:03Z

Parent Install Page

github-actions · 2026-04-24T09:31:21Z

Student Install Page

github-actions · 2026-04-24T09:33:24Z

Teacher Install Page

Copilot

Pull request overview

Updates Help Menu E2E test selectors and expectations to match recent Help Menu copy/link changes across Parent, Student, and Teacher apps.

Changes:

Replaced the “Submit a Feature Idea” Help Menu entry strings with “Share a Contribution” in shared test constants.
Updated Help Page test page objects to locate/assert the renamed Help Menu item.
Updated Help Menu E2E tests to expect the new “Share a Contribution” destination URL.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
automation/espresso/src/main/kotlin/com/instructure/canvas/espresso/StringConstants.kt	Renames shared Help Menu string constants used by UI/E2E tests.
apps/teacher/src/androidTest/java/com/instructure/teacher/ui/pages/classic/HelpPage.kt	Updates Teacher Help dialog selectors/assertions to the new menu item title/subtitle.
apps/teacher/src/androidTest/java/com/instructure/teacher/ui/e2e/classic/HelpMenuE2ETest.kt	Updates expected intent URL for the renamed menu item.
apps/student/src/androidTest/java/com/instructure/student/ui/pages/classic/HelpPage.kt	Updates Student Help dialog selectors/assertions to the new menu item title/subtitle.
apps/student/src/androidTest/java/com/instructure/student/ui/e2e/classic/HelpMenuE2ETest.kt	Updates expected intent URL for the renamed menu item.
apps/parent/src/androidTest/java/com/instructure/parentapp/ui/pages/classic/HelpPage.kt	Updates Parent Help dialog selectors/assertions to the new menu item title/subtitle.
apps/parent/src/androidTest/java/com/instructure/parentapp/ui/e2e/classic/HelpMenuE2ETest.kt	Updates expected intent URL for the renamed menu item.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-04-24T12:43:10Z

@@ -57,7 +57,7 @@ class HelpPage : BasePage(R.id.helpDialog) {
    /**
     * The label for submitting a feature idea.


The KDoc above this label is now inaccurate (it still mentions submitting a feature idea). Update it to reflect the new 'Share a Contribution' menu item to avoid misleading future test maintenance.

Suggested change

* The label for submitting a feature idea.

* The label for sharing a contribution.

Copilot · 2026-04-24T12:43:11Z

     * The label for submitting a feature idea.
     */
-    private val submitFeatureLabel by OnViewWithStringTextIgnoreCase("Submit a Feature Idea")
+    private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")


This view matcher hard-codes the label text. Since the canonical title exists as HelpMenu.SHARE_A_CONTRIBUTION_TITLE, consider referencing that constant here to avoid future breakages if the UI string changes again.

Suggested change

private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")

private val shareContributionLabel by OnViewWithStringTextIgnoreCase(HelpMenu.SHARE_A_CONTRIBUTION_TITLE)

Copilot · 2026-04-24T12:43:11Z

     * Clicks on the 'Submit a Feature Idea' help menu.
     */
    private fun clickSubmitFeatureLabel() {


The method name and KDoc still refer to 'Submit a Feature Idea', but it now clicks the 'Share a Contribution' item. Consider renaming the function (and updating call sites in the when-branch) so the code reflects current behavior and is easier to follow.

Suggested change

* Clicks on the 'Submit a Feature Idea' help menu.

*/

private fun clickSubmitFeatureLabel() {

* Clicks on the 'Share a Contribution' help menu.

*/

private fun clickShareContributionLabel() {

Copilot · 2026-04-24T12:43:11Z

    private val searchGuidesLabel by OnViewWithText(R.string.searchGuides)
    private val reportProblemLabel by OnViewWithStringTextIgnoreCase("Report a Problem")
-    private val submitFeatureLabel by OnViewWithStringTextIgnoreCase("Submit a Feature Idea")
+    private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")


This view matcher hard-codes the menu label text. Since HelpMenu.SHARE_A_CONTRIBUTION_TITLE is the canonical value used elsewhere in this class, use that constant here to prevent string drift across tests.

Suggested change

private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")

private val shareContributionLabel by OnViewWithStringTextIgnoreCase(HelpMenu.SHARE_A_CONTRIBUTION_TITLE)

Copilot · 2026-04-24T12:43:11Z

    fun clickSubmitFeatureLabel() {
-        submitFeatureLabel.scrollTo().click()
+        shareContributionLabel.scrollTo().click()
    }


This function name no longer matches its behavior (it clicks 'Share a Contribution'). Consider renaming it (and updating the when-branch that calls it) to keep the page object API self-explanatory.

Copilot · 2026-04-24T12:43:12Z

    private val reportProblemLabel by OnViewWithStringTextIgnoreCase("Report a Problem")

-    private val submitFeatureLabel by OnViewWithStringTextIgnoreCase("Submit a Feature Idea")
+    private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")


This view matcher hard-codes the menu label text. Prefer using HelpMenu.SHARE_A_CONTRIBUTION_TITLE here to keep the selector consistent with the rest of the assertions and avoid future string changes breaking the test.

Suggested change

private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")

private val shareContributionLabel by OnViewWithStringTextIgnoreCase(HelpMenu.SHARE_A_CONTRIBUTION_TITLE)

Copilot · 2026-04-24T12:43:12Z

    private fun clickSubmitFeatureLabel() {
-        submitFeatureLabel.scrollTo().click()
+        shareContributionLabel.scrollTo().click()
    }


The helper method name still refers to submitting a feature, but it now clicks 'Share a Contribution'. Consider renaming the method and updating the when-branch call so the intent assertion logic reads clearly.

Fix breaking Help Menu E2E tests in all the apps (Changed some string…

7b3d28c

…s and Intent URLS) refs: MBL-19970 affects: Parent, Student, Teacher release note: -

Fix click shareContributionLabel method text in parent and teacher.

db45017

kdeakinstructure requested review from adamNagy56 and Copilot April 24, 2026 12:39

Copilot started reviewing on behalf of kdeakinstructure April 24, 2026 12:40 View session

Copilot AI reviewed Apr 24, 2026

View reviewed changes

adamNagy56 approved these changes Apr 24, 2026

View reviewed changes

		@@ -57,7 +57,7 @@ class HelpPage : BasePage(R.id.helpDialog) {
		/**
		* The label for submitting a feature idea.

	* The label for submitting a feature idea.
	* The label for sharing a contribution.

	private val shareContributionLabel by OnViewWithStringTextIgnoreCase("Share a Contribution")
	private val shareContributionLabel by OnViewWithStringTextIgnoreCase(HelpMenu.SHARE_A_CONTRIBUTION_TITLE)

Conversation

kdeakinstructure commented Apr 24, 2026

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🧪 Unit Test Results

✅ 📱 Parent App

✅ 📱 Student App

✅ 📱 Teacher App

✅ 🌅 Horizon

✅ 📦 Submodules

📊 Summary

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

📊 Code Coverage Report

✅ Student

✅ Teacher

✅ Pandautils

📈 Overall Average

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Apr 24, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Copilot AI Apr 24, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading

github-actions Bot commented Apr 24, 2026 •

edited

Loading