Skip to content

[MBL-19946][S/T/P] Add session cookie renewal when app goes online#4011

Merged
vargaat merged 2 commits intomasterfrom
bugfix/MBL-19946-Fix-session-cookie-renewal
Apr 27, 2026
Merged

[MBL-19946][S/T/P] Add session cookie renewal when app goes online#4011
vargaat merged 2 commits intomasterfrom
bugfix/MBL-19946-Fix-session-cookie-renewal

Conversation

@vargaat
Copy link
Copy Markdown
Collaborator

@vargaat vargaat commented Apr 24, 2026

What's new?

  • Extracted cookie refresh logic to a separate service and refactored to combine so it was easier to extend.
  • Added extra refresh cycle when the app becomes online.

PR Info

refs: MBL-19946
builds: Student, Teacher, Parent
affects: Student, Teacher, Parent
release note: Fixed an issue that occasionally caused embedded rich content to display the login screen after app goes online.

Test Plan

  • Check scenario in ticket.
  • Test if periodic cookie renewal still works.
  • Check if cookie is present and embedded content (anything inside an iframe like studio LTI) displays properly.

Checklist

  • Tested on phone
  • Tested on tablet

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 24, 2026

PR Checks

Commit: Fix mainactor annotation missing from test target. (a5bfb63)
Built At: Apr 24 16:33 UTC (04/24 10:33 AM MDT)

✅ PR Description
✅ Copyright Headers
✅ SwiftLint
✅ Build CITests
✅ Unit Tests
✅ Code Coverage

@bitrise
Copy link
Copy Markdown
Contributor

bitrise Bot commented Apr 24, 2026

Builds

Commit: Fix mainactor annotation missing from test target. (a5bfb63)
Build Number: 1897
Built At: Apr 24 18:35 CEST (04/24 10:35 AM MDT)

Student
Teacher
Parent

Copy link
Copy Markdown
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code +1

Copy link
Copy Markdown
Contributor

@suhaibabsi-inst suhaibabsi-inst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Tested on iPhone 16, iOS 26.

Copy link
Copy Markdown
Contributor

@petkybenedek petkybenedek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA +1

Copy link
Copy Markdown
Contributor

@rh12 rh12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code + 1

@vargaat vargaat merged commit 370d1b4 into master Apr 27, 2026
8 checks passed
@vargaat vargaat deleted the bugfix/MBL-19946-Fix-session-cookie-renewal branch April 27, 2026 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants