feat(ui-drilldown,ui-options,ui): rework Drilldown#2469
Open
feat(ui-drilldown,ui-options,ui): rework Drilldown#2469
Conversation
ToMESSKa
commented
Mar 18, 2026
Comment on lines
+63
to
+65
| // points to another component's theme ID to display its theme variables | ||
| // (e.g. Drilldown.Group uses Options theme, so themeId: "Options") | ||
| themeId?: string |
Contributor
Author
There was a problem hiding this comment.
Drilldown displays the token of Options in some of its subcomponents, so I implemented this functionality without the theme.ts files like in v11_6
|
matyasf
requested changes
Mar 19, 2026
Collaborator
matyasf
left a comment
There was a problem hiding this comment.
Can you please write about the token changes in the upgrade guide? While the Drilldown tokens itself havent changed, its using other components which did, so just a sentence like "Drilldown.Option is an Options.Item, Drilldown.Separator an Options.Separator under the hood, so token the token changes are the same"
Otherwise it looks good, nice work!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
INSTUI-4792
ISSUE:
TEST PLAN: