[TESTING][SYCL] Enable new offload driver by default for SYCL #20570
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
enable_new_offload_model_default
branch
from
982225f to
1b0769c
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
enable_new_offload_model_default
branch
from
1b0769c to
c5466d7
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
mdtoguchi
reviewed
Nov 18, 2025
| if (const Arg *A = Args.getLastArg(options::OPT_fsycl_targets_EQ)) { | ||
| for (const char *Val : A->getValues()) { | ||
| llvm::Triple TT(C.getDriver().getSYCLDeviceTriple(Val)); | ||
| if ((!TT.isSPIROrSPIRV()) || TT.isSPIRAOT()) |
Contributor
There was a problem hiding this comment.
This doesn't look to handle values like intel_gpu_pvc or other non-Triple related values for AMD and NVidia. Unclear why we need to have this specific check though, testing for the new offload model for SYCL should only care about -fsycl usage. -fsycl-targets is just a modifier for what -fsycl does.
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
enable_new_offload_model_default
branch
from
c5466d7 to
b1f16c7
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
enable_new_offload_model_default
branch
from
b1f16c7 to
75026bb
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
enable_new_offload_model_default
branch
from
798ea83 to
75026bb
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is created for testing SYCL E2E test that are failing with new offloading model, and will not be merged.