Skip to content

Reduce build warnings: fix field reordering and conditionally drop isystem w/a #2407

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
guangyey merged 8 commits into from
Nov 28, 2025
Merged

Reduce build warnings: fix field reordering and conditionally drop isystem w/a #2407

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
abf71ff
Silence warnings
Silv3S Nov 25, 2025
83f5800
Explicitly skip sycl host compiler warnings
Silv3S Nov 25, 2025
af93a58
Fix and unskip no-reorder
Silv3S Nov 25, 2025
8215527
Unskip warnings
Silv3S Nov 25, 2025
3d47638
Restore isystem for older oneAPI versions
Silv3S Nov 26, 2025
0884a28
Restore removed flag
Silv3S Nov 26, 2025
b291259
Update cmake/BuildFlags.cmake
Silv3S Nov 27, 2025
7c4ec9e
Merge branch 'main' into dev/ssiwek/silence_warnings
Silv3S Nov 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions cmake/BuildFlags.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,9 +55,11 @@ macro(set_build_flags)
# SYCL headers, such as deprecated warnings, even if warned API is not actually used in the program.
# We expect that this issue will be addressed in the later version of DPC++ compiler. To workaround
# the issue we wrap paths to SYCL headers in `-isystem`.
foreach(FLAGS IN LISTS SYCL_INCLUDE_DIR)
list(APPEND SYCL_HOST_FLAGS "-isystem ${FLAGS}")
endforeach()
if(__INTEL_LLVM_COMPILER LESS 20250300)
foreach(FLAGS IN LISTS SYCL_INCLUDE_DIR)
list(APPEND SYCL_HOST_FLAGS "-isystem ${FLAGS}")
endforeach()
endif()
# Excluding warnings which flood the compilation output
# TODO: fix warnings in the source code and then reenable them in compilation
list(APPEND SYCL_HOST_FLAGS -Wno-sign-compare)
Expand Down
4 changes: 2 additions & 2 deletions src/ATen/native/xpu/sycl/AdaptiveAveragePooling2dKernels.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -695,15 +695,15 @@ struct AdaptiveAvgPool2dKernelFunctor_cl {
numel_(numel) {}

private:
vec_t* output_;
const vec_t* input_;
int ih_;
int iw_;
int ob_;
int oc_;
int oh_;
int ow_;
int64_t numel_;
const vec_t* input_;
vec_t* output_;
};

#define LAUNCH_AVGPOOL_CHANNEL_LAST_VEC( \
Expand Down
Loading