fix: correct unevaluatedProperties typo in public-incoming-payment schema#28
Open
Onyx2406 wants to merge 1 commit into
Open
fix: correct unevaluatedProperties typo in public-incoming-payment schema#28Onyx2406 wants to merge 1 commit into
Onyx2406 wants to merge 1 commit into
Conversation
…hema The `public-incoming-payment` schema used `unresolvedProperites: false` which is not a valid OpenAPI 3.1 keyword and is silently ignored. The intent was `unevaluatedProperties: false` (matching the usage in auth-server.yaml) to prevent additional properties on the schema. Without this fix, code generators and validators treat public-incoming-payment as allowing arbitrary extra properties.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
public-incoming-paymentschema inresource-server.yamlusesunresolvedProperites: false— a misspelling that is not a valid OpenAPI 3.1 keyword. It is silently ignored by all validators and code generators.The intended keyword is
unevaluatedProperties: false, which is correctly used inauth-server.yaml(line 478).Impact: Without this fix, any code generator or validator treats the
public-incoming-paymentschema as allowing arbitrary additional properties, which defeats the intent of the constraint.Change
resource-server.yaml, line 999