fix(api/paywall): return paymentId with pending entitlement#738
Merged
Conversation
Deployment results
Logs #26504923531 |
sidvishnoi
changed the title
paymentId along with entitlementpaymentId with pending entitlement
There was a problem hiding this comment.
Pull request overview
Updates the paywall entitlement flow so that when a matching payment exists but is still pending, the API response can include the paymentId needed by clients to poll /paywall/paywall-status until completion/failure.
Changes:
- Rename
hasPayment→findPaymentand return{ status, paymentId }instead of onlystatus. - Extend
/paywall/entitlementresponse to includepaymentIdwhen entitlement ispending. - Update payments DB unit tests to validate the new
findPaymentreturn shape.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| api/src/utils/payments-db.ts | Renames lookup helper and returns paymentId alongside mapped status. |
| api/src/utils/payments-db.test.ts | Adjusts assertions to the new findPayment return shape. |
| api/src/routes/paywall/entitlement.ts | Includes paymentId in response only for pending entitlement. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
DarianM
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If payment status is
pendingwhen we're checking entitlement, we want to be able to call/paywall/paywall-statusAPI to poll the payment status until it reaches 'complete' or 'failed'. We require thepaymentIdavailable in that case.Part of #727 (unhappy path)