feat: Automatically approve blocked deposits#2198
Open
MihaiAndrei98 wants to merge 2 commits into
Open
Conversation
github-actions
Bot
added
package: wallet/backend
dragosp1011
reviewed
May 25, 2026
| } | ||
| } | ||
|
|
||
| async approveTransactions() { |
Contributor
There was a problem hiding this comment.
asa the trx are GateHub trx, I think it should be in gatehub service
dragosp1011
reviewed
May 25, 2026
| url, | ||
| JSON.stringify(payload) | ||
| ) | ||
| return response |
Contributor
There was a problem hiding this comment.
leave a new line between blocks and returns for better readability
dragosp1011
reviewed
May 25, 2026
| async approveTransactions() { | ||
| try { | ||
| const transactions = await this.gateHubClient.getPendingTransactions() | ||
| const pendingTransactions = transactions.filter( |
Contributor
There was a problem hiding this comment.
is this filter necessary?
Contributor
There was a problem hiding this comment.
I agree, getPendingTransactions should already filter for state=3
dragosp1011
reviewed
May 25, 2026
|
|
||
| async processResources() { | ||
| process.nextTick(() => this.processPendingTransactions()) | ||
| setInterval( |
Contributor
There was a problem hiding this comment.
use the same approach with setTimeout after getting a response, this why the next processing will be set only after the previous one finishes and it will avoid parallel processing in case of slow responses
dragosp1011
reviewed
May 25, 2026
| try { | ||
| await this.gateHubClient.approvePendingTransactions(transaction.uuid) | ||
| } catch (err) { | ||
| console.error(`Error: ${err}`) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
Changes
Got list of pending manual approval transactions from GateHub
Automatically approved above transactions.