Skip to content

Conversation

@the-glu
Copy link
Contributor

@the-glu the-glu commented Dec 10, 2025

This PR add support of recording failing queries, improving debugging abilities, fixing #1292

It does require this PR on implicitdict side to support 'self' definition: interuss/implicitdict#27 (Reason of CI not passing)

Output look like that in the report:

image

Previously the first query with the timeout would not be present.

@BenjaminPelletier
Copy link
Member

I think this is a great, clever solution. Approval pending full checks passage which should (just now) be unblocked by implicitdict 4.1.0.

@the-glu
Copy link
Contributor Author

the-glu commented Jan 8, 2026

I think this is a great, clever solution. Approval pending full checks passage which should (just now) be unblocked by implicitdict 4.1.0.

Thanks for the review and the release, I just pushed the lock file with latest version and CI is now passing.

I had to fix an error in hygiene that I thought it was in implicit dict, so there is a slight change to handle Self in manage_schema_types as well: https://github.com/interuss/monitoring/compare/dadc944717df4df83283326053489727dee30d71..ef1608a760417bb3104c8f33554576826e2f6739

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants