fix: Prevent non-external links from opening in new tab #417
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@developerjamiu is attempting to deploy a commit to the Invertase Team on Vercel. A member of the Team first needs to authorize it. |
|
To view this pull requests documentation preview, visit the following URL: docs.page/invertase/docs.page~417 Documentation is deployed and generated using docs.page. |
Ehesp
approved these changes
Apr 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting target to undefined still causes the browser to treat it as a value, often opening the link in a new tab. This fix ensures target="_blank" is only set when the link is external, preventing unexpected navigation for internal links.