Skip to content

ci: fix tests by using correct iOS version#431

Merged
russellwheatley merged 3 commits intomainfrom
restore-ci
Mar 30, 2026
Merged

ci: fix tests by using correct iOS version#431
russellwheatley merged 3 commits intomainfrom
restore-ci

Conversation

@russellwheatley
Copy link
Copy Markdown
Member

@russellwheatley russellwheatley commented Mar 30, 2026

Description

Type of Change

  • feat -- New feature (non-breaking change which adds functionality)
  • 🛠️ fix -- Bug fix (non-breaking change which fixes an issue)
  • ! -- Breaking change (fix or feature that would cause existing functionality to change)
  • 🧹 refactor -- Code refactor
  • ci -- Build configuration change
  • 📝 docs -- Documentation
  • 🗑️ chore -- Chore

Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the iosVersion constant from '13.0' to '15.0' in two locations within packages/flutterfire_cli/test/configure_test.dart to satisfy the requirements of current Firebase iOS packages. Feedback was provided to extract this duplicated constant into a single shared variable at a higher scope to improve maintainability and prevent the values from becoming out of sync in the future.

@russellwheatley russellwheatley merged commit fd69a95 into main Mar 30, 2026
6 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant