Skip to content

fix(ios, sdk): constrain transitive dependencies more tightly #8074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(ios, sdk): constrain transitive dependencies more tightly #8074

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/analytics/RNFBAnalytics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,13 +45,13 @@ Pod::Spec.new do |s|
raise "Firebase/AnalyticsWithoutAdIdSupport requires firebase-ios-sdk 7.11.0 or greater."
end

s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', firebase_sdk_version
s.dependency 'Firebase/AnalyticsWithoutAdIdSupport', "<= #{firebase_sdk_version}"
else
if !defined?($RNFirebaseAnalyticsWithoutAdIdSupport)
Pod::UI.puts "#{s.name}: Using default Firebase/Analytics with Ad Ids. May require App Tracking Transparency. Not allowed for Kids apps."
Pod::UI.puts "#{s.name}: You may set variable `$RNFirebaseAnalyticsWithoutAdIdSupport=true` in Podfile to use analytics without ad ids."
end
s.dependency 'Firebase/Analytics', firebase_sdk_version
s.dependency 'Firebase/Analytics', "<= #{firebase_sdk_version}"

# Special pod for on-device conversion
if defined?($RNFirebaseAnalyticsEnableAdSupport) && ($RNFirebaseAnalyticsEnableAdSupport == true)
Expand All @@ -69,7 +69,7 @@ Pod::Spec.new do |s|
raise "GoogleAppMeasurementOnDeviceConversion requires firebase-ios-sdk 9.0.0 or greater."
end

s.dependency 'GoogleAppMeasurementOnDeviceConversion', firebase_sdk_version
s.dependency 'GoogleAppMeasurementOnDeviceConversion', "<= #{firebase_sdk_version}"
end

if defined?($RNFirebaseAsStaticFramework)
Expand Down
2 changes: 1 addition & 1 deletion packages/app-check/RNFBAppCheck.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/AppCheck', firebase_sdk_version
s.dependency 'Firebase/AppCheck', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/app-distribution/RNFBAppDistribution.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/AppDistribution', firebase_sdk_version
s.dependency 'Firebase/AppDistribution', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/app/RNFBApp.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/CoreOnly', firebase_sdk_version
s.dependency 'Firebase/CoreOnly', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/auth/RNFBAuth.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Auth', firebase_sdk_version
s.dependency 'Firebase/Auth', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
4 changes: 2 additions & 2 deletions packages/crashlytics/RNFBCrashlytics.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Crashlytics', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'
s.dependency 'Firebase/Crashlytics', "<= #{firebase_sdk_version}"
s.dependency 'FirebaseCoreExtension', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/database/RNFBDatabase.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Database', firebase_sdk_version
s.dependency 'Firebase/Database', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/dynamic-links/RNFBDynamicLinks.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/DynamicLinks', firebase_sdk_version
s.dependency 'Firebase/DynamicLinks', "<= #{firebase_sdk_version}"
s.dependency 'GoogleUtilities/AppDelegateSwizzler'

if defined?($RNFirebaseAsStaticFramework)
Expand Down
2 changes: 1 addition & 1 deletion packages/firestore/RNFBFirestore.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Firestore', firebase_sdk_version
s.dependency 'Firebase/Firestore', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/functions/RNFBFunctions.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Functions', firebase_sdk_version
s.dependency 'Firebase/Functions', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/in-app-messaging/RNFBInAppMessaging.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/InAppMessaging', firebase_sdk_version
s.dependency 'Firebase/InAppMessaging', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/installations/RNFBInstallations.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Installations', firebase_sdk_version
s.dependency 'Firebase/Installations', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
4 changes: 2 additions & 2 deletions packages/messaging/RNFBMessaging.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,8 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Messaging', firebase_sdk_version
s.dependency 'FirebaseCoreExtension'
s.dependency 'Firebase/Messaging', "<= #{firebase_sdk_version}"
s.dependency 'FirebaseCoreExtension', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/perf/RNFBPerf.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Performance', firebase_sdk_version
s.dependency 'Firebase/Performance', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/remote-config/RNFBRemoteConfig.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/RemoteConfig', firebase_sdk_version
s.dependency 'Firebase/RemoteConfig', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
2 changes: 1 addition & 1 deletion packages/storage/RNFBStorage.podspec
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ Pod::Spec.new do |s|
end

# Firebase dependencies
s.dependency 'Firebase/Storage', firebase_sdk_version
s.dependency 'Firebase/Storage', "<= #{firebase_sdk_version}"

if defined?($RNFirebaseAsStaticFramework)
Pod::UI.puts "#{s.name}: Using overridden static_framework value of '#{$RNFirebaseAsStaticFramework}'"
Expand Down
Loading
Loading