Skip to content

Conversation

@mikehardy
Copy link
Collaborator

Description

These have all been well-reviewed and are the core of a couple follow-on PRs even

main keeps moving along though and this branch attracts entropic failures, so in discussion with Russell we're going to land these three commits then rebase the further v8-deprecation work off main

Related issues

No related issues, but the v8 APIs need to be removed and we have to follow a deprecation cycle to do so

Release Summary

3 conventional commits, semantic release will handle them nicely

Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
    • Yes
  • My change supports the following platforms;
    • Android
    • iOS
  • My change includes tests;
    • e2e tests added or updated in packages/\*\*/e2e
    • jest tests added or updated in packages/\*\*/__tests__
  • I have updated TypeScript types that are affected by my change.
  • This is a breaking change;
    • Yes
    • No

Test Plan

So much testing - all Russell's work on the jest area 💪


Think react-native-firebase is great? Please consider supporting the project with any of the below:

@vercel
Copy link

vercel bot commented Feb 3, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-native-firebase ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 3, 2025 1:25pm

@mikehardy mikehardy added the Workflow: Pending Merge Waiting on CI or similar label Feb 3, 2025
@mikehardy mikehardy removed the Workflow: Pending Merge Waiting on CI or similar label Feb 3, 2025
@mikehardy mikehardy enabled auto-merge (rebase) February 3, 2025 13:46
@mikehardy mikehardy disabled auto-merge February 3, 2025 13:46
@mikehardy mikehardy merged commit 72b0c47 into main Feb 3, 2025
19 checks passed
@mikehardy mikehardy deleted the v8-deprecations branch February 3, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants