Skip to content

Fix layout overflowing to navigation bar & blackbar issue when keyboard is active#145

Open
mloremi wants to merge 1 commit intoionic-team:masterfrom
mloremi:master
Open

Fix layout overflowing to navigation bar & blackbar issue when keyboard is active#145
mloremi wants to merge 1 commit intoionic-team:masterfrom
mloremi:master

Conversation

@mloremi
Copy link
Copy Markdown

@mloremi mloremi commented Mar 26, 2020

this is a fix for these bugs:
#117
#132

@rmartin94
Copy link
Copy Markdown

Is there a way to install this pull request and try it out? I can't make it work by adding the file changes and re-building the app in android

@jakob-p
Copy link
Copy Markdown

jakob-p commented Dec 2, 2020

The change in Line 140
return r.bottom;

makes the view height to small in my app, if i revert it back to

return r.bottom - r.top;

this pull request fixes the resizeOnFullScreen issue mentioned in #117 for me 👍

@boomfly
Copy link
Copy Markdown

boomfly commented Dec 13, 2020

It working.
Fix black bar above keyboard & soft buttons overlap webview.
+1 to merge

@ebhsgit
Copy link
Copy Markdown

ebhsgit commented Dec 14, 2020

@jakob-p
Are you using full screen mode?

The changes in this PR seems to assume the content is in full screen mode.

This assumption is incorrect. Because some pages in an app may not be in full screen mode. And some users of the plugin may incorrectly set the resizeOnFullScreen and not use full screen mode at all.

I made my PR separately, and is very similar to the changes in this PR. My PR checks for full screen mode and applies the appropriate height.

Anyway, try out changes in my PR #156, and let me know if it fixes your issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants