[fix][iOS 17 beta] screen not scrolled when keyboard displayed on IOS 17 beta#177
Open
powowbox wants to merge 1 commit intoionic-team:masterfrom
Open
[fix][iOS 17 beta] screen not scrolled when keyboard displayed on IOS 17 beta#177powowbox wants to merge 1 commit intoionic-team:masterfrom
powowbox wants to merge 1 commit intoionic-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Perhaps the issue will be fix on the final version of iOS 17. If it shouldn't be the case, here is a fix.
The keyboard height is not correct the first time callbacks onKeyboardWillShow and onKeyboardDidShow are displayed. The value is 44 instead of an awaited value around 300.
Since the next time the callbacks are called, the height value is correct, it seems enough to ignore the first calls by setting a guard when the keyboard height is too low to be the right one.