fix(input-password-toggle): improve screen reader announcements #30885
+6
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number: resolves internal
What is the current behavior?
The
ion-input-password-togglebutton usesrole="switch"witharia-checked, causing screen readers like VoiceOver to announce both a state ("On/Off") and an action ("Show/Hide password"). This results in confusing, redundant output such as "On, Hide Password" or "Off, Show Password".What is the new behavior?
The password toggle button now uses
aria-pressedinstead ofrole="switch"witharia-checked. Screen readers announce the action-based label ("Show password" or "Hide password") along with the pressed state, and properly announce state changes when the button is activated.Does this introduce a breaking change?
Other information
Old Preview
New Preview
Current dev build: