Open
Conversation
Wires `filecoin-pin import` into action.yml as a peer to IPFS Cluster, Kubo, and Filebase, so setting `filecoin-wallet-key` satisfies the at-least-one-provider gate. Same root CID is preserved (no repacking). New inputs: - `filecoin-wallet-key`: gates the entire upload step. - `filecoin-network`: defaults to `mainnet`; set `calibnet` for testing. - `filecoin-min-runway-days`, `filecoin-max-balance`: required when wallet key is set, no defaults. Both cap wallet spend per run; the right value depends on the caller's traffic and budget, so we force an explicit choice rather than picking one that could drain a wallet. - `filecoin-pin-version`: pinned to `0.20.1` (first release with `--min-runway-days` and `--max-balance` on `--auto-fund`). The step bakes in a fork-PR fence (same-repo events only), so a non-maintainer PR author cannot trigger USDFC deposits. action.yml top-level description drops the stale Storacha mention and now lists the active providers. Storacha-specific code paths are otherwise untouched and remain deprecated; full removal is a separate concern. Companion to #49 (docs-only composition recipe). Both branches are intended to be shown to upstream maintainers to choose between.
lidel
commented
May 4, 2026
Comment on lines
+328
to
+330
| # Block fork PRs from this wallet-spending step: same-repo events only, | ||
| # so non-maintainer authors cannot trigger USDFC deposits. | ||
| if: ${{ inputs.filecoin-wallet-key != '' && (github.event_name != 'pull_request' || github.event.pull_request.head.repo.full_name == github.event.pull_request.base.repo.full_name) }} |
Contributor
Author
There was a problem hiding this comment.
The step bakes in a fork-PR fence (same-repo events only), so a non-maintainer PR author cannot trigger USDFC deposits, but we dont have that limitation for other pin providers, so maybe not necessary?
lidel
commented
May 5, 2026
| # Capture output so we can dump it in the step summary even on failure | ||
| # (debugging insufficient USDFC, runway, provider issues, etc). | ||
| EXIT=0 | ||
| npx -y filecoin-pin@${{ inputs.filecoin-pin-version }} import build.car \ |
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wires
filecoin-pin importinto action.yml as a peer to IPFS Cluster, Kubo, and Filebase, so settingfilecoin-wallet-keysatisfies the at-least-one-provider gate.New inputs:
filecoin-wallet-key: gates the entire upload step.filecoin-network: defaults tomainnet; setcalibnetfor testing.filecoin-min-runway-days,filecoin-max-balance: required when wallet key is set, no defaults. Both cap wallet spend per run; the right value depends on the caller's traffic and budget, so we force an explicit choice rather than picking one that could drain a wallet.filecoin-pin-version: pinned to0.20.1(first release with--min-runway-daysand--max-balanceon--auto-fund).This is alternative to #49 (docs-only composition recipe). TBD which one is chosen -- cc @BigLep @rvagg @SgtPooki for visibility and feedback