Skip to content

AMS-Lyudmyla Baron - #18

Open
lxs07a wants to merge 7 commits into
ironhack-miami-webdev-october-2017:masterfrom
lxs07a:master
Open

AMS-Lyudmyla Baron#18
lxs07a wants to merge 7 commits into
ironhack-miami-webdev-october-2017:masterfrom
lxs07a:master

Conversation

@lxs07a

@lxs07a lxs07a commented Nov 12, 2018

Copy link
Copy Markdown

No description provided.

@IronhackAMS

Copy link
Copy Markdown

Nice job Lyudmyla! The website itself is offcourse really basic in your case, but you get the point of the exercise;)
Small tip: when you working with partials, for example a navbar, save them as _navbar.hbs with an underscore so that's clear that you implement partials in your other handlebar files.
As a bonus: try to separate also your routes from your app.js in your file architecture. Ideally you only want to upload all the npm's with require + your middleware in app.js
Kido

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants