[MAD DE 1022] Jadde Suarez - #55
Open
jaddesuarez wants to merge 15 commits into
Open
Conversation
…ction changes location of npm in instructions to make easier to understand
update readme
ta-web-mad
reviewed
Nov 10, 2022
ta-web-mad
left a comment
ta-web-mad
left a comment
There was a problem hiding this comment.
Hola Jadde!
He visto que has hecho una cosa un poco extraña y que has hecho el pull request a un repo que no tocaba.
Por lo demas esta todo perfecto, no hay mucho que comentar. He visto que al final conseguiste lo del archivo de la base de datos que conmigo te dio fallo y te comente que lo cambiases a index.
Muy buen trabajo, sigue asi!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
interaction: all
difficulty: medium
comments: had some fire with .then method