[3.3] Support alt-az mounts with lateral offsets in domes #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghilios
reviewed
Jun 7, 2025
ghilios
reviewed
Jun 7, 2025
Contributor
Author
|
This is currently awaiting field testing. |
CuongNv-01
pushed a commit
to starpx1/nina
that referenced
this pull request
Sep 6, 2025
isbeorn
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds specific support for alt-az mounts under domes, with support for specifying an OTA's lateral offset from the mount's center. A new
ALT_AZmember is added toMountTypeEnum.RA/Dec of the mount is converted to Alt-Az values for Y and Z axis rotation. Offsets are applied for mount position in the 4 cardinal directions and up/down positioning, then applies any lateral offset. The
latitudeFactorreverses the orientation for the southern hemisphere.