Skip to content

Cookie SignOut and RNG.Dispose Fix #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
msgavin wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Cookie SignOut and RNG.Dispose Fix #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd74b38
Update AppHarbor.Web.Security/CookieAuthenticator.cs
msgavin Jan 11, 2013
e3097ee
Update AppHarbor.Web.Security/SymmetricEncryption.cs
msgavin Jan 11, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions AppHarbor.Web.Security/CookieAuthenticator.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ public void SignOut()
_context.Response.Cookies.Add(new HttpCookie(_configuration.CookieName, "")
{
Expires = DateTime.UtcNow.AddMonths(-100),
Domain = _configuration.Domain
});
}

Expand Down
12 changes: 1 addition & 11 deletions AppHarbor.Web.Security/SymmetricEncryption.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,17 +33,7 @@ public override byte[] Encrypt(byte[] valueBytes, byte[] initializationVector)
{
initializationVector = new byte[_algorithm.BlockSize / 8];
var rng = RandomNumberGenerator.Create();
try
{
rng.GetBytes(initializationVector);
}
finally
{
if (rng != null)
{
((IDisposable)rng).Dispose();
}
}
rng.GetBytes(initializationVector);

}
using (var output = new MemoryStream())
Expand Down