feat: implement approval state machine (Task 13) - #10
Merged
Conversation
itenev
commented
Jun 7, 2026
Owner
added 2 commits
June 7, 2026 23:27
- Add DB methods for action proposals and fatigue prevention - Create approval.py with cooldown, escalation, and grouping logic - Add 12 tests covering fatigue rules, escalation, and proposal grouping - Update hermes-implementation-plan.md to mark Task 13 complete
- Move `import uuid` to module level in database.py - Fix `Optional[callable]` to `Optional[Callable[..., None]]` in approval.py - Fix `get_pending_proposals` to use f-string for SQLite datetime parameter - Add test_should_propose_action_suppressed - Add test_check_timeout_escalation_no_escalation - Add test_group_pending_proposals_empty
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.