feat: Phase 5 design doc and pre-testing hardening - #16
Closed
loki-hermes-agent[bot] wants to merge 1 commit into
Closed
feat: Phase 5 design doc and pre-testing hardening#16loki-hermes-agent[bot] wants to merge 1 commit into
loki-hermes-agent[bot] wants to merge 1 commit into
Conversation
- Added docs/runbook-synthesis.md outlining synthesis algorithm, minimum data requirements, and human review gate. - Created missing runbooks: validator_duty_misses.yaml and client_crash.yaml. - Added hermes_alive heartbeat metric to processor.py using prometheus-client. - Created docs/prometheus-alerts.yml with HermesAgentSilent and WebhookReceiverDown rules. - Created root Dockerfile for hermes-agent and added __main__ entry point to processor.py.
Owner
|
this pr will be split into atomic prs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepares the project for functional testing on the eth-docker deployment and lays the groundwork for Phase 5.
Changes:
docs/runbook-synthesis.mddetailing the synthesis algorithm, minimum data requirements (10+ resolved incidents), output format (runbooks/drafts/), and the mandatory human review gate.runbooks/validator_duty_misses.yamlandrunbooks/client_crash.yamlto provide meaningful test coverage for common failure modes.prometheus-clientdependency and implementedhermes_aliveGauge inprocessor.py, exposed via an HTTP server on port 8091. This enables theHermesAgentSilentalert.docs/prometheus-alerts.ymlcontainingHermesAgentSilentandWebhookReceiverDownalert rules as specified in the design docs.Dockerfileforhermes-agent(usinguv) and added anif __name__ == "__main__":block toprocessor.pyso it can be run directly aspython -m agentic_node_ops.processor.Type of Change
Testing
pytest -v --cov=agentic_node_ops --cov=webhook_receiver— 161 tests passed, 89% coverage)ruff check&ruff format) applied and passingChecklist