Fix ARM build and add libneo branch auto-detection#1
Draft
krystophny wants to merge 1 commit into
Draft
Conversation
Use -mcpu=native instead of -march=native on ARM targets, as gfortran does not recognize -march=apple-m3 resolved from -march=native. Add get_branch_or_main logic for TIAGO_LIBNEO_TAG: automatically use the matching libneo branch if it exists, otherwise fall back to main. This enables coordinated branch-based development across repos (e.g. dep-audit/decompose-neo-core). Ref: itpplasma/libneo#274
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
-march=nativeon ARM: use-mcpu=nativewhich gfortran recognizes on Apple Siliconget_branch_or_mainlogic forTIAGO_LIBNEO_TAG: auto-detect matching libneo branch instead of always defaulting tomainThe virtual-casing targets (
tiago_vacuum_cli,test_tiago_with_simsopt_grid) have a pre-existing C++ runtime link failure (___gxx_personality_v0from Fortran linker) unrelated to this change. The maintiago_cliexecutable builds successfully.Test plan
tiago_clibuilds on Apple Silicon against decomposed libneo-mcpu=nativepath only activates on ARM)