feat: type-safe, idiomatic Rust API (closes #20)#34
Open
MavenRain wants to merge 1 commit intoitzmeanjan:mainfrom
Open
feat: type-safe, idiomatic Rust API (closes #20)#34MavenRain wants to merge 1 commit intoitzmeanjan:mainfrom
MavenRain wants to merge 1 commit intoitzmeanjan:mainfrom
Conversation
Introduce PieceCount and PieceByteLen newtypes to prevent parameter swapping at call sites. Drop get_ prefixes on all getters per Rust API guidelines. Rename get_decoded_data to into_decoded_data to follow the consuming-method convention. Remove error variants made impossible by the new types (PieceLengthZero, PieceLengthTooShort). Decoder::new is now infallible since the newtypes guarantee non-zero inputs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce PieceCount and PieceByteLen newtypes to prevent parameter swapping at call sites. Drop get_ prefixes on all getters per Rust API guidelines. Rename get_decoded_data to into_decoded_data to follow the consuming-method convention. Remove error variants made impossible by the new types (PieceLengthZero, PieceLengthTooShort). Decoder::new is now infallible since the newtypes guarantee non-zero inputs.